Internet on Android needs android.permission.INTERNET - how to add?

[joonas-fi]

I couldn't use the network from my app, which I found to be surprising. I decompiled the .apk to check AndroidManifest.xml to find out it's missing the INTERNET permission.

It seems like there isn't a way to add extra permissions from command line, since the permissions are hardcoded:

fyne/cmd/fyne/internal/mobile/manifest.go

Line 79 in 57a9489

<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />

Am I expected to supply custom manifest file? I couldn't find from documentation a mention of how to do it.

My workaround was (I'm using fyne-cross):

• Fork fyne
• Patch the hardcoded manifest to include the permission, re-compile $ fyne
• Derive a new Docker image for fyne-cross by replacing the fyne binary with my custom one
• Use $ fyne-cross android -image=MY_CUSTOM_IMAGE

The patch was (NOTE: it's missing the also-recommended ACCESS_NETWORK_STATE):

diff --git a/cmd/fyne/internal/mobile/manifest.go b/cmd/fyne/internal/mobile/manifest.go
index 96884fd1..29b6a2f5 100644
--- a/cmd/fyne/internal/mobile/manifest.go
+++ b/cmd/fyne/internal/mobile/manifest.go
@@ -78,4 +78,5 @@ var manifestTmpl = template.Must(template.New("manifest").Parse(`
 
        <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
        <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
+       <uses-permission android:name="android.permission.INTERNET" />
 </manifest>`))

[andydotxyz]

If your app has an AndroidManifest.xml then the compiler will use that instead.

[joonas-fi]

Great to hear that there is a solution!

I couldn't find this behaviour from the documentation, it would be helpful for newcomers like me if this is mentioned somewhere accessible.

Would you like me to send a PR to developer.fyne.io repo? Perhaps this page, my rough proposal:

• New heading, "Platform-specific considerations, Android"?
• Text: "Network inaccessible by default, you have to supply custom AndroidManifest.xml", with link to this issue (your answer specifically) so we don't have to write as much text in the documentation?

[AlbinoGeek]

@joonas-fi I think this should be documented, yes--as inevitably I was going to ask this question 👍🏻

[andydotxyz]

I've updated for internet on by default from 2.0.2.
The metadata work we're doing for 2.1 can have the option to turn this off #1431.

[andydotxyz]

Resolved on develop and will be added to next release.