[Android 11] Light Theme Unusable (no "system safe area")

[AlbinoGeek]

Describe the bug:

When the system is using the DarkVariant but the application is using the Light Theme, the user experience could be described as "unusable". The hardware navigation buttons and notification area "disappear entirely" due to the use of white on white.

To Reproduce:

Steps to reproduce the behaviour:

1. Have your system's Dark Mode enabled
2. Run the fyne demo from the appstore

Screenshots:

Peek.2021-03-03.10-52.mp4

Device (please complete the following information):

• OS: Android 11 - Samsung Galaxy S20+ Ultra 5G
• Go version: N/A
• Fyne version: v2.0.0 ?

[andydotxyz]

This seems like a duplicate of #472

[AlbinoGeek]

The request for a "system safe area" (e.g: fyne has no business theming the hardware buttons, for example) -- still stands, separate of the implementation of reflecting the system theme, I feel.

Whether your app has the right to theme the hardware buttons is up to whether it has the "True Fullscreen" flag set (in Android), and is not standard behavior.

[andydotxyz]

The system safe area is already implemented.
We draw the background colour into that space area so that it does not get random graphics context drawn instead.
Once this is synced with the device theme it should function as you'd expect.

[AlbinoGeek]

Ahh, thank you for the clarification.

…

On Thu., Mar. 25, 2021, 12:07 p.m. Andy Williams, ***@***.***> wrote: The system safe area is already implemented. We draw the background colour into that space area so that it does not get random graphics context drawn instead. Once this is synced with the device theme it should function as you'd expect. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2058 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOSNPJX7V3AA4UR2GMIMWTTFOCYBANCNFSM4YRZEFZQ> .

[andydotxyz]

So, is this a duplicate afterall?

[AlbinoGeek]

Yes. This can be closed as duplicate.

…

On Thu., Mar. 25, 2021, 2:49 p.m. Andy Williams, ***@***.***> wrote: So, is this a duplicate afterall? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2058 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOSNPOMHEA6HBOQ4B7MHF3TFOVV3ANCNFSM4YRZEFZQ> .