Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mobile] Advanced Color picker keeps updating values forever after modifying it with sliders #2075

Closed
fpabl0 opened this issue Mar 9, 2021 · 3 comments
Closed

[mobile] Advanced Color picker keeps updating values forever after modifying it with sliders #2075

fpabl0 opened this issue Mar 9, 2021 · 3 comments
Labels
blocker Items that would block a forthcoming release bug Something isn't working Driver:mobile Issues relating to the mobile driver specifically
Milestone
2.0.x - bugfixes ...

Comments

@fpabl0
Copy link
Member

fpabl0 commented Mar 9, 2021

Describe the bug:

Advanced Color picker dialog keeps updating values forever after modifying it with sliders.

To Reproduce:

Steps to reproduce the behaviour:

  1. Run fyne_demo with mobile tag.
  2. Click on Dialogs and then click on Advance Color Picker.
  3. Try to change color channels values by moving the sliders.
  4. See the error.

Screenshots:

colour-picker-bug.mp4

Device (please complete the following information):

  • OS: MacOS
  • Version: 10.15.4 Catalina
  • Go version: 1.16
  • Fyne version: develop @ 912d8d8
@fpabl0 fpabl0 added bug Something isn't working Driver:mobile Issues relating to the mobile driver specifically labels Mar 9, 2021
@andydotxyz
Copy link
Member

In my testing this seems to happen with the HSL sliders but not with the RGB...
However I suspect that is just a coincidence as the code works OK on desktop mode which would imply the mobile drag code is faulty.

@fpabl0
Copy link
Member Author

fpabl0 commented Mar 10, 2021

However I suspect that is just a coincidence as the code works OK on desktop mode which would imply the mobile drag code is faulty

Yes, I would say the same.

@andydotxyz andydotxyz added the blocker Items that would block a forthcoming release label Mar 22, 2021
@fpabl0 fpabl0 mentioned this issue Mar 23, 2021
Merged
3 tasks
fpabl0 added a commit that referenced this issue Mar 26, 2021
@fpabl0
Merge pull request #2109 from fpabl0/fix/2075
1a6c38f 
Do not double update color channels when their associated entry text is changed programmatically, fixes #2075
@andydotxyz
Copy link
Member

Fix now on develop and release/v2.0.x for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker Items that would block a forthcoming release bug Something isn't working Driver:mobile Issues relating to the mobile driver specifically
Projects
None yet
Milestone
2.0.x - bugfixes since binding, stora...
Development

No branches or pull requests
2 participants
@andydotxyz @fpabl0