Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create empty shortcuts #2148

Closed
andydotxyz opened this issue Apr 8, 2021 · 2 comments
Closed

Don't create empty shortcuts #2148

andydotxyz opened this issue Apr 8, 2021 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
2.0.x - bugfixes ...

Comments

@andydotxyz
Copy link
Member

Describe the bug:

When typing out a keyboard shortcut like "Ctr-A", first an empty "-Ctrl" shortcut is sent, which should not be

To Reproduce:

Steps to reproduce the behaviour:

  1. Implement TypedShortcut
  2. Print the content of any desktop.CustomShortcut
  3. Notice that the first is always listing LeftControl or RightControl as the KeyName

Device (please complete the following information):

  • OS: darwin
  • Version: Catalina
  • Go version: 1.16
  • Fyne version: 2.0.2
@andydotxyz andydotxyz added the bug Something isn't working label Apr 8, 2021
@andydotxyz andydotxyz added the good first issue Good for newcomers label Apr 16, 2021
@AnkushJadhav AnkushJadhav mentioned this issue Apr 19, 2021
Merged
3 tasks
@andydotxyz
Copy link
Member Author

On develop for testing, thanks @AnkushJadhav

@andydotxyz
Copy link
Member Author

This is also on release/v2.0.x ready for v2.0.3 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
2.0.x - bugfixes since binding, stora...
Development

No branches or pull requests
1 participant
@andydotxyz