New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tapped triggered after Drag #2235
Comments
This is really strange. I cannot replicate it within the Entry widget adding debug lines on |
P.S. your example is not using the version of Fyne you think it is - that's v1 |
Yes very strange, I also could not replicate with Entry. Can you reproduce with the provided code sample? I can reproduce in two ways; with a go.mod containing
Yup, it had the v2 suffix when I ran it with v2.0.3, but then I removed it and changed the go.mod so I could test with v1.3.3. I've edited the original message to re-add the v2 suffix. |
yes I can. But I can’t quite understand how it happens here but not in entry. More work required to hunt down the cause I think.
goodness I’m sorry, misread your message - I was convinced you were reporting against develop and v2.0.3. Oops. |
I wonder if it is because Entry implements more interfaces than this example (ie. the desktop MouseIn/Move/Out) so it takes a slightly different path through the driver |
You are probably right about that. I have tagged 2.0.x in case we get a simple fix on this before any other patch releases go out. |
not sure i follow correctly but why not just: fyne/internal/driver/glfw/window.go Line 823 in 3814a66
to: if button == desktop.MouseButtonSecondary && altTap && !mouseDragStarted {
and fyne/internal/driver/glfw/window.go Line 831 in 3814a66
to: if action == glfw.Release && button == desktop.MouseButtonPrimary && !mouseDragStarted {
|
I think you are probably right @s77rt |
On |
Merged to |
Describe the bug:
Tapped is triggered after Drag which can interfere with the user interface; consider the selection scenario where the user can tap to select, or drag to define a rectangle selection. The user drags out a selection but after they release the mouse the selection gets dropped and instead the single element under the mouse gets selected.
Example code:
Aside:
In v1.3.3 the Tapped is triggered after the last Drag, but before the DragEnd so it was possible to maintain a
dragging bool
and ignore Tapped if dragging == true.v2.0.3
v1.3.3
Device (please complete the following information):
The text was updated successfully, but these errors were encountered: