Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have widget.Button embed a widget.Label instead of canvas.Text for the button label #2378

Closed
EldritchCometh opened this issue Aug 14, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@EldritchCometh
Copy link

EldritchCometh commented Aug 14, 2021

Is your feature request related to a problem? Please describe:

Well there may be more reason than one but what brought this to my attention was the inability to add a new line to the label of the button.

Is it possible to construct a solution with the existing API?

Yes. It should be a relatively simple change. I might even be able to implement it (very poorly).

Describe the solution you'd like to see:

I would like to be able to pass a widget.Label instead of a canvas.Text to widget.NewButton().

@andydotxyz andydotxyz changed the title Have widget.Button receive a widget.Label instead of canvas.Text for the button label Have widget.Button embed a widget.Label instead of canvas.Text for the button label Aug 15, 2021
@andydotxyz
Copy link
Member

This seems like something we could do internally, it wouldn't be a breaking change.
Likely even more beneficial now that we have RichText.

@andydotxyz andydotxyz added the enhancement New feature or request label Aug 15, 2021
@andydotxyz andydotxyz added this to the Aberlour (2.1) milestone Aug 15, 2021
andydotxyz added a commit that referenced this issue Aug 27, 2021
@andydotxyz
Copy link
Member

On develop for testing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants