-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SetIcon method on ToolbarAction #2475
Add SetIcon method on ToolbarAction #2475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the PR and your first contribution to Fyne :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, just one thing missed here, sorry!
@@ -27,8 +27,14 @@ func (t *ToolbarAction) ToolbarObject() fyne.CanvasObject { | |||
return button | |||
} | |||
|
|||
// SetIcon updates the icon on a ToolbarItem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a new API we need to have a since line. Please add (including the line to separate):
//
// Since: 2.2
The next feature release will probably be 2.2, so we pick this version in anticipation of the next larger release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks for this. I will merge it shortly, just wrangling some v2.1.1 fixes first which this needs to come after
Merged on develop, the first feature addition for Bowmore release :) |
Description:
SetIcon
method onToolbarAction
ToolbarAction
,ToolbarSpacer
, andToolbarSeparator
now return their concrete type instead of genericToolbarItem
interface. This would allow us to add more methods if needed in future to those structs.Fixes #2040
Checklist:
Example