Correct all version used while building application to ensure Windows… #3638
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jacalz This is why you do not get a working binary on Windows at the moment when fyne-cross use fyne to build. We would want this patch to be in the minor release, I think. |
|
Are you sure this is the cause @Bluebugs ? The metadata that is being used does have 3 version digits and a build... |
|
Indeed. It seems like that shouldn't quite impact my use case? |
|
@Jacalz indeed, their was another bug in geoffrey that was preventing this also to work. It was a small one in fyne-cross, this one here and one more in geoffrey. |
andydotxyz
approved these changes
Feb 8, 2023
|
Agreed, it isn't the root of the problem but is a good improvement anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Compiling for Windows with a short AppVersion, like 1.0, lead to the version not being consistent from Windows perspective and prevent the starting of the application on up to date Windows.
Checklist: