Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in font metrics cache #4108

Closed
2 tasks done
dweymouth opened this issue Jul 31, 2023 · 1 comment · Fixed by #4119
Closed
2 tasks done

Memory leak in font metrics cache #4108

dweymouth opened this issue Jul 31, 2023 · 1 comment · Fixed by #4119
Labels
bug Something isn't working

Comments

@dweymouth
Copy link
Contributor

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

The fontSize cache here is only cleaned out on settings change, and it stores arbitrary user-supplied strings in the map key. It should be made an expiring cache and have expired entries cleaned out during the periodic clean task.

How to reproduce

Run fyne_demo and scroll through all rows of the list/table demos, or any other text-heavy Fyne app.

Screenshots

No response

Example code

fyne-demo

Fyne version

develop

Go compiler version

go1.19.4 darwin/amd64

Operating system and version

Mac OS

Additional Information

No response

@dweymouth dweymouth added the unverified A bug that has been reported but not verified label Jul 31, 2023
@dweymouth dweymouth linked a pull request Aug 2, 2023 that will close this issue
3 tasks
@Jacalz Jacalz added bug Something isn't working and removed unverified A bug that has been reported but not verified labels Aug 2, 2023
@andydotxyz
Copy link
Member

Thanks @dweymouth for resolving this (on develop) for v2.4.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants