Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar does not display in both markup and image test rendering #4738

Open
2 tasks done
Bluebugs opened this issue Mar 24, 2024 · 1 comment
Open
2 tasks done

Toolbar does not display in both markup and image test rendering #4738

Bluebugs opened this issue Mar 24, 2024 · 1 comment
Labels
unverified A bug that has been reported but not verified

Comments

@Bluebugs
Copy link
Contributor

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

When upgrading shopping to fyne 2.4.4, my test broke. We assumed it was just some change affecting the markup output and that the toolbar being 0 pixels was ok. It is actually breaking also the image tests.

If you add a line to render and check against pixels at the same line as the markup failing one here like the following: test.AssertRendersToImage(t, "shopping_list_new_item.png", a.win.Canvas()). This will give the following result:

shopping_list_new_item

Notice the absence of toolbar at the bottom right of the window.

How to reproduce

  1. Pull the branch from Bump fyne.io/fyne/v2 from 2.4.3 to 2.4.4 Bluebugs/shopping#35
  2. Add test.AssertRendersToImage(t, "shopping_list_new_item.png", a.win.Canvas()) at line 118 in https://github.com/Bluebugs/shopping/blob/main/ui_test.go
  3. Check the resulting picture.

Screenshots

No response

Example code

Example code is as in the git repository. I do not have a smaller example.

Fyne version

2.4.4

Go compiler version

1.22.1

Operating system and version

Arch Linux

Additional Information

No response

@Bluebugs Bluebugs added the unverified A bug that has been reported but not verified label Mar 24, 2024
@andydotxyz
Copy link
Member

My understanding was that it was just the toolbar when inside tabs that were not currently visible. I guess this means that was incorrect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unverified A bug that has been reported but not verified
Projects
None yet
Development

No branches or pull requests

2 participants