Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key events not blocked by overlays #814

Closed
toaster opened this issue Apr 5, 2020 · 2 comments · Fixed by #1454
Closed

Key events not blocked by overlays #814

toaster opened this issue Apr 5, 2020 · 2 comments · Fixed by #1454
Assignees
Labels
blocker Items that would block a forthcoming release bug Something isn't working

Comments

@toaster
Copy link
Member

toaster commented Apr 5, 2020

Describe the bug:

When opening a pop-up (like the menu) the overlay should catch all events. This works well for mouse events but keyboard events are still forwarded to the window's content.

Maybe this isn't fixable by generic event blocking in overlays. When a pop-up belongs to a form widget (Select or EntrySelect), the <TAB>-key should probably close the pop-up.

To Reproduce:

Steps to reproduce the behaviour:

  1. Open demo app without native menus
  2. Open the Widget->Input pane
  3. Click on a menu
  4. Press <TAB> until the entry widget has focus
  5. Enter some text
  6. See error

Screenshots:

keyboard_events_with_open_menu

@toaster
Copy link
Member Author

toaster commented Sep 17, 2020

This is partly fixed with #1318 which fixes the focus handling for overlays.
However, the menu part is still open.

@toaster toaster mentioned this issue Oct 23, 2020
3 tasks
toaster added a commit that referenced this issue Oct 24, 2020
@andydotxyz
Copy link
Member

This has a pretty solid solution on develop now, thanks @toaster.
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Items that would block a forthcoming release bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants