Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development Experience concerns #129

Open
loginov-rocks opened this issue Oct 4, 2018 · 1 comment
Open

Development Experience concerns #129

loginov-rocks opened this issue Oct 4, 2018 · 1 comment

Comments

@loginov-rocks
Copy link

Hi guys!

I found this project very interesting in the long term, however and may be I'm wrong, but it seems that it's hard to on board to contribute into this projects since it's not clear what is an input and output of each UI component. For example both themes have it's own component realization that's why you need tests for each of them. Also it's hard to switch from one theme to another depending on the clients OS.

Just an idea why not to extract the components codebase itself having all possible props declared and handled in place and separate macOS and Windows styles as themes. I saw issue talking about styled-components, that's a great idea, but it will be hard to rewrite everything in a moment because of all conditions.

And I see that Functional Components & Recompose are a good tools to refactor codebase to. When the props declaration will be in place it'd be easy to generate consistent docs. And having styles splitted from the implementation it'd be easy to add other themes like for Ubuntu/Windows Classic/etc.

@gabrielbull
Copy link
Owner

Hello @1oginov. At this point, this library is not actively maintained and is looking for contributors. You seem to have good ideas on where to take this project and if you looking to contribute I would be happy to add you as a maintainer. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants