fix: dont skip first update or plain components

gaearon · Apr 13, 2019 · 432e0f8 · 432e0f8
1 parent c5af009
commit 432e0f8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/reactHotLoader.js b/src/reactHotLoader.js
@@ -46,9 +46,6 @@ const reactHotLoader = {
       const proxy = getProxyById(id)
 
       if (proxy && proxy.getCurrent() !== type) {
-        // component got replaced. Need to reconcile
-        incrementGeneration()
-
         if (!reactHotLoader.IS_REACT_MERGE_ENABLED) {
           if (
             isTypeBlacklisted(type) ||
@@ -74,6 +71,7 @@ const reactHotLoader = {
 
       registerComponent(updateProxyById(id, type, options).get(), 2)
       registerComponent(type)
+      incrementGeneration()
     }
     if (isContextType({ type })) {
       // possible options - Context, Consumer, Provider.

diff --git a/test/reactHotLoader.test.js b/test/reactHotLoader.test.js
@@ -112,16 +112,16 @@ describe('reactHotLoader', () => {
       const oldGeneration = getGeneration()
       reactHotLoader.register(Div, 'Div', 'reactHotLoader.test.js')
       // new thing, no change
-      expect(getGeneration()).toBe(oldGeneration + 0)
+      expect(getGeneration()).toBe(oldGeneration + 1)
 
       reactHotLoader.register(Div, 'Div', 'reactHotLoader.test.js')
       // no replacement
-      expect(getGeneration()).toBe(oldGeneration + 0)
+      expect(getGeneration()).toBe(oldGeneration + 2)
 
       const NewDiv = () => <div />
       reactHotLoader.register(NewDiv, 'Div', 'reactHotLoader.test.js')
       // replacement!
-      expect(getGeneration()).toBe(oldGeneration + 1)
+      expect(getGeneration()).toBe(oldGeneration + 3)
     })
 
     it('should ignore dom elements and incomplete signature', () => {