TypeError: Object(...)(...) is not a function

[jeetiss]

Description

no semicolon code style in node_modules breaks hmr

Expected behavior

all work nice

Actual behavior

What actually happens:

TypeError: Object(...)(...) is not a function

Reproducible Demo

repo with bug and steps to reproduce
https://github.com/jeetiss/gatsby-hmr-bug

[theKashey]

Sooo easy? Why nobody reported it before?

[theKashey]

However - that did not help.

• ; is lost during rollup bundling.
• ; is added by webpack plugin itself
• the problem does exist only for node_modules in the SRC - the code from webpack plugin is just DIFFERENT - without ";", that somehow is bound to the source map generation
• I am just changing IIFE mode (to !function) to prevent the issue.

[theKashey]

The best fix - scope webpack loader to react-dom

[jeetiss]

the problem does exist only for node_modules in the SRC

@theKashey this not right
I am update example with npm package that breaks hmr

https://github.com/jeetiss/module-that-breaks-hmr

[jeetiss]

@theKashey thanks for help ❤️

[theKashey]

If you will compare the final result for "normal" node modules, and your ones - it's different.
How it works in short:

• you are given a source
• I am reading webpackTagCommonJSExports.js
• I am concatenating source and patch with "\n\n;" as a glue.

Usually: - everything is working as expected
For "your" modules: - there is no glue, plus some comments which should not be present.

And that's not quite explainable.