Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper names #80

Open
Thriliriel opened this issue Mar 3, 2022 · 2 comments
Open

Proper names #80

Thriliriel opened this issue Mar 3, 2022 · 2 comments

Comments

@Thriliriel
Copy link

Is your feature request related to a problem? Please describe.
I am not sure if it would be a bug or merely a new feature, because i am not sure if you thought about this when building the model. Running some tests locally i found out that the KeyToText has issues to build a logical sentence when we pass a proper name (people names, like John or Paul) in the keywords. For example, if i pass the keywords [John, have, dog, cat], it builds "A cat and a dog are having a play date.". If i exchange John for man ([man, have, dog, cat]), it builds something much better ("A man has a cat and a dog").

Describe the solution you'd like
Maybe there is already an option which i was too dumb to find, but it would be nice if the model was able to be used with proper names as well.

Describe alternatives you've considered
Assuming that the model indeed has this issue, my first guess would be the training database, but i am no ML expert =)

@gagan3012
Copy link
Owner

The model training dataset has no proper names and any sentences that contained a proper name were removed too. this was done to reduce bias

@Thriliriel
Copy link
Author

I see, thank you for your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants