semi rule doesn't check class properties

[mikaello]

I seems like eslint-plugin-flowtype does not detect props: <PropsObject> or the state / defaultProps Flow annotations inside ES6 classes.

Excerpt from React section in Flow-docs:

type Props = {
  title: string,
  visited: boolean,
  onClick: () => void,
};

class Button extends React.Component {
  props: Props;

  state: {
    display: 'static' | 'hover' | 'active',
  };

  static defaultProps: { visited: boolean };

  /* clipped */
}

.eslintrc

// ...
"flowtype/semi": [2, "never"],
// ...

I get (correct) error on type Props = { ... };, Extra semicolon. (flowtype/semi), but no errors on props: Props; or any of the other Flow annotations inside Button-class.

Is this intentional, or not part of what eslint-plugin-flowtype is supposed to cover?

[danharper]

Yep, this is a bug and not intentional.

[gajus]

🎉 This issue has been resolved in version 5.1.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀