Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require-exact-type must not add exact types for explicitly inexact types #444

Closed
apsavin opened this issue Mar 31, 2020 · 2 comments
Closed

Comments

@apsavin
Copy link

apsavin commented Mar 31, 2020

With rule

"flowtype/require-exact-type": [
      2,
      "always"
    ]

The following code

type A = { a: string, ... }

Becomes

type A = {| a: string, ... |}

Which is incorrect.

"eslint-plugin-flowtype": "^4.7.0",

@gajus
Copy link
Owner

gajus commented Mar 31, 2020

Should be a simple fix and a good first PR.

@gajus gajus closed this as completed in 4238464 May 15, 2020
@gajus
Copy link
Owner

gajus commented May 15, 2020

🎉 This issue has been resolved in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants