You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recommended config now uses @babel/eslint-parser. This should be a breaking change for consumers, the only difference should be that eslint how uses a projects babel config to read files which may cause issues if the babel config has exclusions setup based on environment variables that don't play nice with eslint.
What's the reason babel-eslint is kept as a dependency?
babel-eslint is a dev-dependency of this project is because the eslint rules of this project don't use itself, the dependency here also isn't what is shipped as a requirement to the user.
What's the reason @babel/eslint-parser is not a dependency?
This project doesn't use @babel/eslint-parser again because of the eslint rules it extends from are not itself. The current version of canonical eslint still uses babel-eslinthttps://github.com/gajus/eslint-config-canonical/blob/v20.1.0/configurations/eslintrc.json#L7. We can upgrade this as part of a separate PR because updating the dev dependencies here is not really the goal of this PR
Overall what i'm trying to do here is just update what is used by the consumer so that they get @babel/eslint-parser out of the box without needing to override babel-eslint not what this project (eslint-plugin-flowtype) internally uses.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #474
Recommended config now uses @babel/eslint-parser. This should be a breaking change for consumers, the only difference should be that eslint how uses a projects babel config to read files which may cause issues if the babel config has exclusions setup based on environment variables that don't play nice with eslint.
This should be a major version bump.
@wilt-rally @gajus