Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: consistent-type-delimeter #500

Open
Brianzchen opened this issue Sep 8, 2021 · 3 comments
Open

feature: consistent-type-delimeter #500

Brianzchen opened this issue Sep 8, 2021 · 3 comments

Comments

@Brianzchen
Copy link
Contributor

I want to see a new rule where I can enforce more consistency on an object type. Currently , or ; can be used between object properties, the rule would enforce one or the other

@mrtnzlml
Copy link
Contributor

mrtnzlml commented Sep 8, 2021

@Brianzchen such consistency can be already achieved with prettier/prettier rule (Prettier already takes care of the consistency). It's true that it forces to use , instead of ; though and I am not sure if it's configurable. Either way, this new rule should be eventually added to https://github.com/prettier/eslint-config-prettier and disable it by default (as we do for many other rules).

@Brianzchen
Copy link
Contributor Author

I don't use prettier and I don't think using flowtype should require me to need prettier so a separate rule here would be best fit since it's only necessary for flow object types. Could we just duplicate that rule here?

@mrtnzlml
Copy link
Contributor

Makes sense. 👍

Could we just duplicate that rule here?

I don't think that's easily possible. I'd expect that the Eslint rule calls Prettier directly and just reports back the errors - so not much to copy here, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants