From 041de5f224773756edb4a658a791ae99eecfc3bf Mon Sep 17 00:00:00 2001 From: Brett Zamir Date: Wed, 13 Apr 2022 19:41:25 +0800 Subject: [PATCH] fix: regression with checking TS MethodDefinition params --- src/jsdocUtils.js | 2 +- test/rules/assertions/requireParam.js | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/src/jsdocUtils.js b/src/jsdocUtils.js index 6bcffaa1a..acdd7a790 100644 --- a/src/jsdocUtils.js +++ b/src/jsdocUtils.js @@ -271,7 +271,7 @@ const getFunctionParameterNames = ( throw new Error(`Unsupported function signature format: \`${param.type}\`.`); }; - return functionNode.params.map((param) => { + return (functionNode.params || functionNode.value.params).map((param) => { return getParamName(param); }); }; diff --git a/test/rules/assertions/requireParam.js b/test/rules/assertions/requireParam.js index 6b075198d..e395c9292 100644 --- a/test/rules/assertions/requireParam.js +++ b/test/rules/assertions/requireParam.js @@ -3366,5 +3366,29 @@ export default { sourceType: 'module', }, }, + { + code: ` + /** + * [A description] + */ + class A { + /** + * @param config + */ + constructor (config: SomeConfig) { + super(config); + } + } + `, + ignoreReadme: true, + options: [ + { + contexts: [ + 'MethodDefinition', + ], + }, + ], + parser: require.resolve('@typescript-eslint/parser'), + }, ], };