fix(check-param-names): properly handle index offset

Author: brettz9

README.md

@@ -3756,6 +3756,20 @@ declare global {
    */
   function foo(this: void, arg1: number): void;
 }
+
+declare global {
+  /**
+   * @param r Range is 0-1.
+   * @param g Range is 0-1.
+   * @param b Range is 0-1.
+   */
+  function Color(
+    this: void,
+    r: float,
+    g: float,
+    b: float,
+  ): Color;
+}
 ````
 
 

src/rules/checkParamNames.js

@@ -36,6 +36,7 @@ const validateParameterNames = (
   });
 
   let dotted = 0;
+  let thisOffset = 0;
 
   // eslint-disable-next-line complexity
   return paramTags.some(([
@@ -64,9 +65,10 @@ const validateParameterNames = (
       return false;
     }
 
-    let functionParameterName = functionParameterNames[index - dotted];
+    let functionParameterName = functionParameterNames[index - dotted + thisOffset];
     if (functionParameterName === 'this') {
-      functionParameterName = functionParameterNames[index - dotted + 1];
+      ++thisOffset;
+      functionParameterName = functionParameterNames[index - dotted + thisOffset];
     }
 
     if (!functionParameterName) {

test/rules/assertions/checkParamNames.js

@@ -1777,5 +1777,23 @@ export default {
       ignoreReadme: true,
       parser: require.resolve('@typescript-eslint/parser'),
     },
+    {
+      code: `
+      declare global {
+        /**
+         * @param r Range is 0-1.
+         * @param g Range is 0-1.
+         * @param b Range is 0-1.
+         */
+        function Color(
+          this: void,
+          r: float,
+          g: float,
+          b: float,
+        ): Color;
+      }
+      `,
+      parser: require.resolve('@typescript-eslint/parser'),
+    },
   ],
 };