fix(require-jsdoc): handle MethodDefinition context without errin…

…g when using `exemptEmptyFunctions` and `exemptEmptyConstructors`; fixes #613 Also impacts `check-params`, `require-params` when using `MethodDefinition` context.
gajus · Jul 20, 2020 · 08b5820 · 08b5820
1 parent eac8357
commit 08b5820
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -9904,6 +9904,12 @@ class Foo {
     constructor() {}
 }
 // Options: [{"checkConstructors":false,"require":{"MethodDefinition":true}}]
+
+class Base {
+  constructor() {
+  }
+}
+// Options: [{"contexts":["MethodDefinition"],"exemptEmptyConstructors":true}]
 ````
 
 

diff --git a/src/jsdocUtils.js b/src/jsdocUtils.js
@@ -177,7 +177,7 @@ const getFunctionParameterNames = (functionNode : Object) : Array<T> => {
     throw new Error('Unsupported function signature format.');
   };
 
-  return functionNode.params.map((param) => {
+  return (functionNode.params || functionNode.value.params).map((param) => {
     return getParamName(param);
   });
 };

diff --git a/test/rules/assertions/requireJsdoc.js b/test/rules/assertions/requireJsdoc.js
@@ -3936,5 +3936,17 @@ export default {
       },
     ],
   },
+  {
+    code: `
+    class Base {
+      constructor() {
+      }
+    }
+    `,
+    options: [{
+      contexts: ['MethodDefinition'],
+      exemptEmptyConstructors: true,
+    }],
+  },
   ],
 };