fix(valid-types): liberalize to allow second path to @borrows to be a…

… name path beginning only with a name path operator, as jsdoc accepts This is essentially allowing jsdoctypeparser's `memberPartWithOperators` here.
gajus · Jun 27, 2019 · 35df873 · 35df873
1 parent f28f87f
commit 35df873
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 9 deletions.
diff --git a/src/rules/validTypes.js b/src/rules/validTypes.js
@@ -18,14 +18,26 @@ export default iterateJsdoc(({
       } catch (err) {
         let error = err;
 
-        if (tagName && ['memberof', 'memberof!'].includes(tagName)) {
-          const endChar = type.slice(-1);
-          if (['#', '.', '~'].includes(endChar)) {
-            try {
-              parse(type.slice(0, -1));
-              error = {};
-            } catch (memberofError) {
-              // Use the original error for including the whole type
+        if (tagName) {
+          if (['memberof', 'memberof!'].includes(tagName)) {
+            const endChar = type.slice(-1);
+            if (['#', '.', '~'].includes(endChar)) {
+              try {
+                parse(type.slice(0, -1));
+                error = {};
+              } catch (memberofError) {
+                // Use the original error for including the whole type
+              }
+            }
+          } else if (tagName === 'borrows') {
+            const startChar = type.charAt();
+            if (['#', '.', '~'].includes(startChar)) {
+              try {
+                parse(type.slice(1));
+                error = {};
+              } catch (memberofError) {
+                // Use the original error for including the whole type
+              }
             }
           }
         }
@@ -49,7 +61,7 @@ export default iterateJsdoc(({
         return;
       }
 
-      if (validTypeParsing(thisNamepath)) {
+      if (validTypeParsing(thisNamepath, 'borrows')) {
         const thatNamepath = tag.name;
 
         validTypeParsing(thatNamepath);

diff --git a/test/rules/assertions/validTypes.js b/test/rules/assertions/validTypes.js
@@ -62,6 +62,20 @@ export default {
         message: 'Syntax error in type: foo%'
       }]
     },
+    {
+      code: `
+          /**
+           * @borrows #foo as bar
+           */
+          function quux() {
+
+          }
+      `,
+      errors: [{
+        line: 3,
+        message: 'Syntax error in type: #foo'
+      }]
+    },
     {
       code: `
           /**
@@ -198,6 +212,16 @@ export default {
           }
       `
     },
+    {
+      code: `
+          /**
+           * @borrows foo as #bar
+           */
+          function quux() {
+
+          }
+      `
+    },
     {
       code: `
           /**