fix(require-returns-check): check WithStatement for return statem…

…ents
gajus · Aug 8, 2019 · 37e8300 · 37e8300
1 parent 19a6590
commit 37e8300
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -6622,6 +6622,16 @@ function quux () {
   }
 }
 
+/**
+ * @returns {true}
+ */
+function quux () {
+  var a = {};
+  with (a) {
+    return true;
+  }
+}
+
 /**
  * @returns {true}
  */

diff --git a/src/jsdocUtils.js b/src/jsdocUtils.js
@@ -276,7 +276,8 @@ const STATEMENTS_WITH_CHILDREN = [
   'SwitchStatement',
   'IfStatement',
   'BlockStatement',
-  'TryStatement'
+  'TryStatement',
+  'WithStatement'
 ];
 
 const RETURNFREE_STATEMENTS = [
@@ -288,7 +289,6 @@ const RETURNFREE_STATEMENTS = [
   'LabeledStatement',
   'DebuggerStatement',
   'EmptyStatement',
-  'WithStatement',
   'ThrowStatement',
   'ExpressionStatement'
 ];
@@ -316,6 +316,14 @@ const lookupTable = {
       return true;
     }
   },
+  WithStatement: {
+    is (node) {
+      return node.type === 'WithStatement';
+    },
+    check (node, context) {
+      return lookupTable.BlockStatement.check(node.body, context);
+    }
+  },
   IfStatement: {
     is (node) {
       return node.type === 'IfStatement';

diff --git a/test/rules/assertions/requireReturnsCheck.js b/test/rules/assertions/requireReturnsCheck.js
@@ -457,6 +457,19 @@ export default {
           }
       `
     },
+    {
+      code: `
+          /**
+           * @returns {true}
+           */
+          function quux () {
+            var a = {};
+            with (a) {
+              return true;
+            }
+          }
+      `
+    },
     {
       code: `
           /**