From 4270b75d7ed3550b4df4f05141dd4abf96741dc7 Mon Sep 17 00:00:00 2001 From: Brett Zamir Date: Wed, 20 Apr 2022 09:52:29 +0800 Subject: [PATCH] fix(`require-jsdoc`): proper reporting of end line numbers; fixes #843 --- src/rules/requireJsdoc.js | 7 ++++++- test/rules/assertions/requireJsdoc.js | 5 +++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/rules/requireJsdoc.js b/src/rules/requireJsdoc.js index a18392280..f70e5abde 100644 --- a/src/rules/requireJsdoc.js +++ b/src/rules/requireJsdoc.js @@ -320,8 +320,13 @@ export default { }; const report = () => { + const { + start, + } = node.loc; const loc = { - end: node.loc.start + 1, + end: { + line: start.line + 1, + }, start: node.loc.start, }; context.report({ diff --git a/test/rules/assertions/requireJsdoc.js b/test/rules/assertions/requireJsdoc.js index 4680b7bc1..f9ebe4445 100644 --- a/test/rules/assertions/requireJsdoc.js +++ b/test/rules/assertions/requireJsdoc.js @@ -226,7 +226,8 @@ function quux (foo) { }`, errors: [ { - endLine: undefined, + column: 1, + endLine: 3, line: 2, message: 'Missing JSDoc comment.', }, @@ -699,7 +700,7 @@ function quux (foo) { }`, errors: [ { - endLine: undefined, + endLine: 3, line: 2, message: 'Missing JSDoc comment.', },