From 5a928db6e158a4c889058be8353da5417d42fedb Mon Sep 17 00:00:00 2001 From: Brett Zamir Date: Fri, 9 Jul 2021 11:24:11 +0800 Subject: [PATCH] fix(`check-examples`): auto-disable `no-empty-function` rule for expression checking; clear it is a no-op in this context --- .README/rules/check-examples.md | 4 +++- README.md | 4 +++- src/rules/checkExamples.js | 1 + 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.README/rules/check-examples.md b/.README/rules/check-examples.md index 5fe95eaa3..2b3cf7d68 100644 --- a/.README/rules/check-examples.md +++ b/.README/rules/check-examples.md @@ -156,10 +156,12 @@ For `checkDefaults`, `checkParams`, and `checkProperties`, the following expression-oriented rules will be used by default as well: * `quotes` - Will insist on "double". -* `semi` - Will insist on "never" +* `semi` - Will insist on "never". * `strict` - Disabled. +* `no-empty-function` - Disabled. * `no-new` - Disabled. * `no-unused-expressions` - Disabled. +* `chai-friendly/no-unused-expressions` - Disabled. ##### Options for checking other than `@example` (`checkDefaults`, `checkParams`, or `checkProperties`) diff --git a/README.md b/README.md index 96621104b..8382ebb88 100644 --- a/README.md +++ b/README.md @@ -1108,10 +1108,12 @@ For `checkDefaults`, `checkParams`, and `checkProperties`, the following expression-oriented rules will be used by default as well: * `quotes` - Will insist on "double". -* `semi` - Will insist on "never" +* `semi` - Will insist on "never". * `strict` - Disabled. +* `no-empty-function` - Disabled. * `no-new` - Disabled. * `no-unused-expressions` - Disabled. +* `chai-friendly/no-unused-expressions` - Disabled. ##### Options for checking other than @example (checkDefaults, checkParams, or checkProperties) diff --git a/src/rules/checkExamples.js b/src/rules/checkExamples.js index 0d275e7c3..84cffd26e 100644 --- a/src/rules/checkExamples.js +++ b/src/rules/checkExamples.js @@ -61,6 +61,7 @@ const defaultMdRules = { const defaultExpressionRules = { ...defaultMdRules, 'chai-friendly/no-unused-expressions': 'off', + 'no-empty-function': 'off', 'no-new': 'off', 'no-unused-expressions': 'off', quotes: ['error', 'double'],