fix(require-jsdoc): avoid exported functions possessing jsdoc blocks …

…causing other non-public functions to be treated as exported; fixes #358
gajus · Aug 30, 2019 · 874adab · 874adab
1 parent 5bb9182
commit 874adab
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -5638,6 +5638,15 @@ const myObject = {
   myProp: true
 };
 // Options: [{"contexts":[]}]
+
+function bear() {}
+/**
+ *
+ */
+function quux () {
+}
+export default quux;
+// Options: [{"publicOnly":true,"require":{"FunctionExpression":true}}]
 ````
 
 

diff --git a/src/exportParser.js b/src/exportParser.js
@@ -340,9 +340,7 @@ const findExportedNode = function (block, node, cache) {
     if (Object.prototype.hasOwnProperty.call(props, key)) {
       blockCache.push(props[key]);
       if (props[key].exported) {
-        // If not always true, we need a test
-        /* istanbul ignore next */
-        if (findNode(node, block)) {
+        if (node === props[key].value || findNode(node, props[key].value)) {
           return true;
         }
       }

diff --git a/test/rules/assertions/requireJsdoc.js b/test/rules/assertions/requireJsdoc.js
@@ -2163,5 +2163,24 @@ export default {
         contexts: [],
       },
     ],
+  }, {
+    code: `
+      function bear() {}
+      /**
+       *
+       */
+      function quux () {
+      }
+      export default quux;
+    `,
+    options: [{
+      publicOnly: true,
+      require: {
+        FunctionExpression: true,
+      },
+    }],
+    parserOptions: {
+      sourceType: 'module',
+    },
   }],
 };