From b32ee6af64c5e430f2036db55d0cc118d12a15d8 Mon Sep 17 00:00:00 2001 From: Sebastian Busch Date: Wed, 15 Jan 2020 10:35:38 +0100 Subject: [PATCH] semver.valid() requires trimmed string With leading or trailing whitespace, semver.valid() returns false --- src/rules/checkValues.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/rules/checkValues.js b/src/rules/checkValues.js index 3067143ac..c3e8abe38 100644 --- a/src/rules/checkValues.js +++ b/src/rules/checkValues.js @@ -15,8 +15,8 @@ export default iterateJsdoc(({ } = options; utils.forEachPreferredTag('version', (jsdocParameter, targetTagName) => { - const version = jsdocParameter.description; - if (!version.trim()) { + const version = jsdocParameter.description.trim(); + if (!version) { report( `Missing JSDoc @${targetTagName}.`, null, @@ -31,8 +31,8 @@ export default iterateJsdoc(({ } }); utils.forEachPreferredTag('since', (jsdocParameter, targetTagName) => { - const version = jsdocParameter.description; - if (!version.trim()) { + const version = jsdocParameter.description.trim(); + if (!version) { report( `Missing JSDoc @${targetTagName}.`, null,