From be3af9d46d5eeee49ecbf1338cf0115df0c01a3b Mon Sep 17 00:00:00 2001
From: Chris Dryden <christopher.paul.dryden@gmail.com>
Date: Thu, 7 Apr 2022 17:57:22 -0700
Subject: [PATCH] chore: drop Node 12 from `engines`

BREAKING CHANGE:

Node 12 is soon entering EOL.

Also:
- perf: remove regextra library to reduce dependencies (#865)
- chore: drop Node 12 and add Node 17 to Travis

Co-authored-by: Brett Zamir <brettz9@yahoo.com>
---
 .travis.yml                                     |  2 +-
 package.json                                    |  3 +--
 src/rules/requireDescriptionCompleteSentence.js | 10 ++--------
 3 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 76ce7bf97..20f4bb454 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -2,9 +2,9 @@ os: linux
 dist: xenial
 language: node_js
 node_js:
-  - "12.22.0"
   - "14.17.0"
   - "16"
+  - "17"
 install:
   - npm install --legacy-peer-deps
 before_script: >
diff --git a/package.json b/package.json
index faa3bec3e..5783f6630 100644
--- a/package.json
+++ b/package.json
@@ -10,7 +10,6 @@
     "debug": "^4.3.4",
     "escape-string-regexp": "^4.0.0",
     "esquery": "^1.4.0",
-    "regextras": "^0.8.0",
     "semver": "^7.3.6",
     "spdx-expression-parse": "^3.0.1"
   },
@@ -48,7 +47,7 @@
     "typescript": "^4.6.3"
   },
   "engines": {
-    "node": "^12 || ^14 || ^16 || ^17"
+    "node": "^14 || ^16 || ^17"
   },
   "keywords": [
     "eslint",
diff --git a/src/rules/requireDescriptionCompleteSentence.js b/src/rules/requireDescriptionCompleteSentence.js
index 4cc0c7a53..bdfc63e1d 100644
--- a/src/rules/requireDescriptionCompleteSentence.js
+++ b/src/rules/requireDescriptionCompleteSentence.js
@@ -1,7 +1,4 @@
 import escapeStringRegexp from 'escape-string-regexp';
-import {
-  RegExtras,
-} from 'regextras/dist/main-umd';
 import iterateJsdoc from '../iterateJsdoc';
 
 const otherDescriptiveTags = new Set([
@@ -25,12 +22,9 @@ const extractSentences = (text, abbreviationsRegex) => {
     // Remove custom abbreviations
     .replace(abbreviationsRegex, '');
 
-  const sentenceEndGrouping = /([.?!])(?:\s+|$)/u;
+  const sentenceEndGrouping = /([.?!])(?:\s+|$)/ug;
 
-  // eslint-disable-next-line unicorn/no-array-method-this-argument
-  const puncts = new RegExtras(sentenceEndGrouping).map(txt, (punct) => {
-    return punct;
-  });
+  const puncts = txt.matchAll(sentenceEndGrouping);
 
   return txt