fix(check-types): for jsdoc mode, avoid objecting to upper-case; f…

…ixes #860
gajus · Mar 28, 2022 · d11d271 · d11d271
1 parent 0f27282
commit d11d271
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -5883,6 +5883,17 @@ function a () {}
  */
 function a () {}
 // Settings: {"jsdoc":{"mode":"typescript","preferredTypes":{"Object":"object","object.<>":"Object<>","object<>":"Object<>"}}}
+
+/**
+ * Does something.
+ *
+ * @param {Object<string,string>} spec - Foo.
+ */
+function foo(spec) {
+    return spec;
+}
+
+foo()
 ````
 
 

diff --git a/src/rules/checkTypes.js b/src/rules/checkTypes.js
@@ -196,8 +196,7 @@ export default iterateJsdoc(({
     let changedPreferred = preferred;
     for (const strictNativeType of strictNativeTypes) {
       if (
-        // Todo: Avoid typescript condition if moving to default typescript
-        strictNativeType === 'object' && mode === 'typescript' &&
+        strictNativeType === 'object' &&
         (
           // This is not set to remap with exact type match (e.g.,
           //   `object: 'Object'`), so can ignore (including if circular)

diff --git a/test/rules/assertions/checkTypes.js b/test/rules/assertions/checkTypes.js
@@ -3003,5 +3003,19 @@ export default {
         },
       },
     },
+    {
+      code: `
+      /**
+       * Does something.
+       *
+       * @param {Object<string,string>} spec - Foo.
+       */
+      function foo(spec) {
+          return spec;
+      }
+
+      foo()
+      `,
+    },
   ],
 };