Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gajus/eslint-plugin-jsdoc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v33.3.0
Choose a base ref
...
head repository: gajus/eslint-plugin-jsdoc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v34.0.0
Choose a head ref
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on May 11, 2021

  1. chore: require engines Node 12+ (#726) 

    BREAKING CHANGE:

Also:
- Build: Switch to Node 12 target
- Linting: Use `flat` API
- Travis: Add Node 16, remove Node 10
- npm: Update devDep.
    @brettz9
    brettz9 authored May 11, 2021
    Copy the full SHA
    a0ee0a6 View commit details
Showing with 5 additions and 8 deletions.
  1. +1 −1 .babelrc.json
  2. +1 −1 .travis.yml
  3. +2 −2 package.json
  4. +1 −4 src/jsdocUtils.js
2 changes: 1 addition & 1 deletion .babelrc.json
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@
"@babel/preset-env",
{
"targets": {
"node": 10
"node": 12
}
}
]
2 changes: 1 addition & 1 deletion .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -2,9 +2,9 @@ os: linux
dist: xenial
language: node_js
node_js:
- 16
- 14
- 12
- 10

before_install:
- npm config set depth 0
4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -36,15 +36,15 @@
"gitdown": "^3.1.4",
"glob": "^7.1.7",
"husky": "^6.0.0",
"lint-staged": "^10.5.4",
"lint-staged": "^11.0.0",
"mocha": "^8.4.0",
"nyc": "^15.1.0",
"rimraf": "^3.0.2",
"semantic-release": "^17.4.2",
"typescript": "^4.2.4"
},
"engines": {
"node": ">=10"
"node": ">=12"
},
"lint-staged": {
".eslintignore": "npm run lint",
5 changes: 1 addition & 4 deletions src/jsdocUtils.js
View file
Original file line number Diff line number Diff line change
@@ -325,10 +325,7 @@ const isValidTag = (
) : boolean => {
const tagNames = getTagNamesForMode(mode, context);

// Todo[engine:node@>=12]: Switch to flatten

// eslint-disable-next-line unicorn/prefer-array-flat -- Not yet supported
const validTagNames = Object.keys(tagNames).concat(_.flatten(Object.values(tagNames)));
const validTagNames = Object.keys(tagNames).concat(Object.values(tagNames).flat());
const additionalTags = definedTags;
const allTags = validTagNames.concat(additionalTags);