Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow empty line between jsdoc and jscode #353

Merged
merged 3 commits into from Jul 23, 2019
Merged

feat: allow empty line between jsdoc and jscode #353

merged 3 commits into from Jul 23, 2019

Conversation

yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Jul 22, 2019 •
edited by brettz9

brettz9
brettz9 requested changes Jul 22, 2019
View reviewed changes
Copy link
Collaborator

@brettz9 brettz9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. I'd just like to see a few more tests:

  1. a passing test where minLines is higher than 0
  2. a failing test where minLines is higher than 1 but there is 1
  3. a failing test where the lines are more than a maxLines setting.
  4. a passing and failing test with a 0 line difference (e.g., failing with a minimum of 1):
/** @lends MyClass */ { 
    // ...methods
}

@yeonjuan
Copy link
Contributor Author

yeonjuan commented Jul 23, 2019 •
edited

@brettz9 commits more test cases. thanks! :)

@brettz9 brettz9 merged commit b5a78ff into gajus:master Jul 23, 2019
@gajus
Copy link
Owner

gajus commented Jul 23, 2019

🎉 This PR is included in version 15.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@brettz9 brettz9 mentioned this pull request Jul 23, 2019
Closed
@gajus gajus added the released label Jul 23, 2019
l1bbcsg pushed a commit to interfaced/eslint-plugin-jsdoc that referenced this pull request Aug 8, 2019
@yeonjuan @l1bbcsg
feat: allow empty line between jsdoc and jscode (gajus#353)
19a6590 
feat(*): have doc block retrieval allow or require additional preceding empty lines via min/max line setting API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettz9 brettz9 brettz9 requested changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow empty line after JS Doc in require-jsdoc rule
3 participants
@yeonjuan @gajus @brettz9