Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atom require-jsdoc #386

Closed
jssuttles opened this issue Sep 26, 2019 · 6 comments · Fixed by #387
Closed

Atom require-jsdoc #386

jssuttles opened this issue Sep 26, 2019 · 6 comments · Fixed by #387
Labels
released

Comments

@jssuttles
Copy link

I'm not sure if this should be handled by this plugin, but when running Atom (with linter-eslint), the jsdoc/require-jsdoc rule causes the entire function to be highlighted.
When running intellij, it just highlights the first line of the function.
I would prefer that it not highlight the entire function.
brettz9 added a commit to brettz9/eslint-plugin-jsdoc that referenced this issue Sep 27, 2019
@brettz9
fix: avoid highlighting whole function block upon missing jsdoc block…
ec89c1f 
… in favor of highlighting first line only; fixes gajus#386
@brettz9 brettz9 mentioned this issue Sep 27, 2019
Merged
golopot pushed a commit that referenced this issue Sep 27, 2019
@brettz9 @golopot
fix: avoid highlighting whole function block upon missing jsdoc block…
f77144d 
… in favor of highlighting first line only; fixes #386
@gajus
Copy link
Owner

gajus commented Sep 27, 2019

🎉 This issue has been resolved in version 15.9.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Sep 27, 2019
@jssuttles
Copy link
Author

Thanks for working on this! However, the problem doesn't seem to be fixed.
image

@jssuttles
Copy link
Author

Nvm. restarted atom and it worked.
Thanks!!!

@jssuttles
Copy link
Author

Here's something I noticed though. It doesn't highlight the first line.
If possible, that would be nice to have since it causes the user to notice.
image

brettz9 added a commit to brettz9/eslint-plugin-jsdoc that referenced this issue Sep 27, 2019
@brettz9
fix(require-jsdoc): have reporting cover entire first line of funct…
3558377 
…ion so more visible; (causes `endLine` to be removed); gajus#386
@brettz9
Copy link
Collaborator

brettz9 commented Sep 27, 2019

You can try updating now to 15.9.5 (and restart Atom again after that).

@jssuttles
Copy link
Author

That's pretty good. I'll take it. 👍
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

require-jsdoc: Highlight first line only of missing jsdoc brettz9/eslint-plugin-jsdoc
3 participants
@brettz9 @gajus @jssuttles