Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

valid-types format for @this fails in Closure Compiler #430

Closed
joeyparrish opened this issue Nov 13, 2019 · 2 comments
Closed

valid-types format for @this fails in Closure Compiler #430

joeyparrish opened this issue Nov 13, 2019 · 2 comments
Labels
bug released

Comments

@joeyparrish
Copy link

In the Closure Compiler, @this requires a type in curly braces, such as @this {Navigator}. However, eslint-plugin-jsdoc's valid-types rule only accepts @this Navigator, which Closure rejects.
@brettz9 brettz9 added the bug label Nov 14, 2019
brettz9 added a commit to brettz9/eslint-plugin-jsdoc that referenced this issue Dec 1, 2019
@brettz9
fix(check-types, no-undefined-types, valid-types): look within …
3b9a474 
…curly brackets of `this` and `define` tag (and optionally within `export`) when in Closure mode; fixes gajus#430
@brettz9 brettz9 closed this as completed in 7022f65 Dec 1, 2019
@gajus
Copy link
Owner

gajus commented Dec 1, 2019

🎉 This issue has been resolved in version 18.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Dec 1, 2019
joeyparrish added a commit to shaka-project/eme-encryption-scheme-polyfill that referenced this issue Dec 2, 2019
@joeyparrish
Upgrade eslint-plugin-jsdoc to fix warnings
9abb349 
Warnings about the `@this` tag are now gone.

gajus/eslint-plugin-jsdoc#430

Thanks, @gajus!
@joeyparrish
Copy link
Author

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettz9 @gajus @joeyparrish