Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiline workaround #744

Merged
merged 6 commits into from May 19, 2021
Merged

Conversation

renatho
Copy link
Contributor

@renatho renatho commented May 18, 2021

It's a workaround for #743.

Basically, it ignores multiline tags. To check it, it'll verify in the tokens if tag is empty and it contains type or name. The ideal solution would be to align it even being multiline.

Copy link
Collaborator

@brettz9 brettz9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix and looks good if you could just review the comments and apply as necessary. Thanks!

src/alignTransform.js Show resolved Hide resolved
src/alignTransform.js Outdated Show resolved Hide resolved
@renatho
Copy link
Contributor Author

renatho commented May 19, 2021

Thank you @brettz9! Changes applied! I also tested it against the Gutenberg repo and it looked okay, although type in multiline it's not common in that code.

@brettz9
Copy link
Collaborator

brettz9 commented May 19, 2021

Thanks If you haven't run npm install locally, please do so, as that will set up a proper environment that will do linting, and automated checks, etc.

Also for next time, if you can run npm run create-readme to update our README (and also make sure we have 100% coverage with npm run test-cov if you aren't doing that already.

Thanks!

@brettz9 brettz9 force-pushed the add/tag-multiline-workaround branch from e65a299 to a880e33 Compare May 19, 2021 16:00
@brettz9 brettz9 merged commit 9928298 into gajus:master May 19, 2021
@gajus
Copy link
Owner

gajus commented May 19, 2021

🎉 This PR is included in version 34.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants