require-returns-check: false-positive with break in switch in other switch

[regseb]

Expected behavior

If a switch contains another switch with a break, the require-returns-check rule shouldn't report an error.

Actual behavior

If a switch contains another switch with a break, the require-returns-check rule report an error.

ESLint Config (in package.json)

{
    "name": "testcase",
    "version": "1.0.0",
    "private": true,
    "dependencies": {
        "eslint": "8.26.0",
        "eslint-plugin-jsdoc": "39.3.17"
    },
    "eslintConfig": {
        "plugins": ["jsdoc"],
        "rules": {
            "jsdoc/require-returns-check": 2
        }
    }
}

ESLint sample

/**
 * @returns Baz.
 */
function foo() {
    switch (true) {
        default:
            switch (true) {
                default: break;
            }
            return "baz";
    }
};

Environment

• Node version: v18.11.0
• ESLint version 8.26.0
• eslint-plugin-jsdoc version: 39.3.17

Additional info

The problem started in version 39.3.15.
Maybe the require-returns-check rule thinks that the break applies to the highest switch.

[brettz9]

Thanks for the report. This should be fixed now, but just be aware the code for checking all branches is fresh and is somewhat involved, so there may be some other areas needing improvement.

[gajus]

🎉 This issue has been resolved in version 39.3.18 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀