Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to read / filter out logs #339

Open
gajus opened this issue Apr 7, 2022 · 1 comment
Open

Make it easier to read / filter out logs #339

gajus opened this issue Apr 7, 2022 · 1 comment

Comments

@gajus
Copy link
Owner

gajus commented Apr 7, 2022

At the moment, every query produces at least 2 log entries:

  • executing query
  • query execution result

The problem:

  • "executing query" is not particularly useful most of the time, unless you are debugging hanging queries.
  • "query execution result" is not particularly useful without "execution query" because it does not contain the query itself, just the query execution ID.

Desired Behavior

Include the actual query into "query execution result".

Motivation

This way, I could filter only by "query execution result" and still have all the necessary context.

Considerations

  • This will increase log weight
  • This doesn't entirely address the underlying problem that I was trying to solve, which is to reduce Datadog logs that we index. If we were to exclude "executing query" log entry, then this would miss valuable information, such as queries that started, but may not have completed during the session.
@janpaepke
Copy link
Contributor

potentially related for considerations: #561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants