Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Card.DIRECTION_UP and Card.DIRECTION_DOWN #55

Open
emicklei opened this issue Nov 6, 2015 · 11 comments
Open

feature: Card.DIRECTION_UP and Card.DIRECTION_DOWN #55

emicklei opened this issue Nov 6, 2015 · 11 comments

Comments

@emicklei
Copy link

emicklei commented Nov 6, 2015

What code changes are required to add these states as well?

@gajus
Copy link
Owner

gajus commented Nov 6, 2015

Telling what changes are required would be equal to writing the code.

@emicklei
Copy link
Author

emicklei commented Nov 6, 2015

:-) i quess you are right. I will make an attempt to it. Thx

@cryptic-mystic
Copy link

cryptic-mystic commented Jun 16, 2016

I've implemented this in my fork. I'd be happy to submit a PR for this and update the docs :)

EDIT: I will summarize all my changes in the PR when I get around to making it

@gajus
Copy link
Owner

gajus commented Jun 16, 2016

@TheCrow1213 That would be appreciated.

@nomanbiniqbal
Copy link

@TheCrow1213 when you are going to publish your changes

@cryptic-mystic
Copy link

@nomanbiniqbal shoot, totally forgot about this. I'll try and merge in my branch this week.

@cryptic-mystic
Copy link

cryptic-mystic commented Sep 28, 2016

Ok, got caught back up on things. I forgot that @Neozaru completed some work I started on this and created a PR, #78. It looks like @elmariachi111 has another PR open with improvements on that one (?), #80.

So I guess we need someone with write access to apply these merges (assuming they pass code review). How can I help @gajus?

@jony89
Copy link

jony89 commented Nov 6, 2016

hey @TheCrow1213, ive talk to @gajus and he has merged #78 but yet we need to bump the package.json version and fix the build (latest eslint is needed )

@gajus could you give one of us permissions so we can keep maintaining this library?

Also additional documentation is needed now.

@gajus
Copy link
Owner

gajus commented Nov 6, 2016

The package.json version is irrelevant as of now. Please read https://github.com/semantic-release/semantic-release. v4.0.0 has been released. All future releases are automated, i.e. whenever a change is merged it will get instantly released using semver convention.

@storyworks
Copy link

Could you publish a demo of the up/down feature, where cards bind to the top or bottom? I wasn't able to get @TheCrow1213's one working nor @elmariachi111's one. Or would someone be able to provide instructions on how to build and compile the project myself so I can get onto writing code?

*I'm pretty new to this and reading through the previous commits needing pragmatist or building with gulp is pretty confusing

@PrithiviRajG
Copy link

Angular2-Swing has feature to swipe up and swipe down, which is using this repo as base. https://github.com/ksachdeva/angular2-swing. can we do something with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants