[FEATURE]: Template helm values files

[salotz]

Feature Request

Background / Motivation

I was trying to template values.yaml files for helm with garden template expansion. This doesn't seem to work.

What should the user be able to do?

Same as manifests the valueFiles should also support garden templates.

Why do they want to do this? What problem does it solve?

The workaround is to use the values section but as mentioned in some other issues (#5738 ) this is severely limited once you have more than 2 different cases/environments.

Also the values section can get very large and overtakes the rest of the config.

Suggested Implementation(s)

N/A

How important is this feature for you/your team?

🌵 Not having this feature makes using Garden painful

[thsig]

Thanks for writing this up!

I wonder if a similar approach to patchResources could be taken here, i.e. something like:

kind: Deploy
type: helm
name: some-service
spec:
  mergeValues: true # <----
  values:
    some:
      deeply:
        nested:
          value: ${var.someOverride}

The mergeValues option could be implemented as follows:

• Resolve the values in the action config
• Read the values file
• Merge in the paths/values from values
• Write the resulting values to a file and pass that to helm
  That way, you wouldn't have to duplicate your whole values file, and could just override the parts you're interested in.

Does that sound like a reasonable flow?

[salotz]

I don't think that is much different than what is currently exists. I don't so much want to override the values files (at least in the scope of the problem I'm currently having), but rather have a way to have specify values for more than 2 cases/environments.

Currently the templates are good at changing the value of a single key-value (like in your example), but if I want to have a more complex nested object I need to use $if: $else templates.

For instance ingresses:

  values:

    $if: ${environment.name == 'local'}
    $then:
      ingress:
        enabled: true
        ingressClassName: nginx 
        tls:
          - hosts:
              - ${var.subdomains["jupyterhub"]}.${var.domain}
            secretName: ingress-tls
       
        hosts:
          - ${var.subdomains["jupyterhub"]}.${var.domain}

    $else:
      ingress:
        enabled: true
        hosts:
          - ${var.subdomains["jupyterhub"]}.${var.domain}
        annotations:
          networking.gke.io/managed-certificates: ${var.helm_release_names["jupyterhub"]}-ingress-cert
          networking.gke.io/v1beta1.FrontendConfig: ${var.helm_release_names["jupyterhub"]}-ingress-frontend
          kubernetes.io/ingress.global-static-ip-name: ${var.static_ips["jupyterhub-staging"]}
          

If instead I can use multiple different values files I can have that structure written out and use the garden templates to fill in the specific values.