Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kcmNodeMonitorGraceDuration optional in the config #101

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Make kcmNodeMonitorGraceDuration optional in the config #101

merged 3 commits into from
Feb 22, 2024

Conversation

rishabh-11
Copy link
Collaborator

@rishabh-11 rishabh-11 commented Feb 20, 2024 •
edited

What this PR does / why we need it:
Make kcmNodeMonitorGraceDuration optional and default its value based on shoot k8s version

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Make `kcmNodeMonitorGraceDuration` optional in the prober config and use a default value of `40s` if not specified in the shoot and the config.

@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Feb 20, 2024
@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 20, 2024
@rishabh-11 rishabh-11 added kind/enhancement Enhancement, improvement, extension and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 20, 2024
@rishabh-11 rishabh-11 removed the request for review from himanshu-kun February 20, 2024 12:57
unmarshall
unmarshall reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Feb 21, 2024

LGTM label has been added.

Git tree hash: 5cc31ee86a4c7891e3a655a77deb29a98fe5ea9c

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@gardener-prow gardener-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2024
unmarshall
unmarshall reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comments

internal/prober/config.go Outdated Show resolved Hide resolved
internal/test/cluster.go Show resolved Hide resolved
@unmarshall
Copy link
Contributor

/approve

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: unmarshall

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@unmarshall
Copy link
Contributor

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Feb 22, 2024

LGTM label has been added.

Git tree hash: 84d31909f2bde1c539c0840888c7844de854670a

@gardener-prow gardener-prow bot merged commit bbb1086 into gardener:master Feb 22, 2024
7 checks passed
@rishabh-11 rishabh-11 deleted the kcm-nmgd branch February 22, 2024 06:04
rishabh-11 added a commit to rishabh-11/dependency-watchdog that referenced this pull request Feb 22, 2024
@rishabh-11
Make kcmNodeMonitorGraceDuration optional in the config (gardener#101)
5814d79 
* make kcmNodeMonitorGraceDuration optional and default its value based on shoot k8s version

* address review comments

* set default value of kcmNodeMonitorGraceDuration as 40s
gardener-prow bot pushed a commit that referenced this pull request Feb 22, 2024
@rishabh-11
Make kcmNodeMonitorGraceDuration optional in the config (#101) (#104)
6181a2a 
* make kcmNodeMonitorGraceDuration optional and default its value based on shoot k8s version

* address review comments

* set default value of kcmNodeMonitorGraceDuration as 40s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall left review comments

@ashwani2k ashwani2k Awaiting requested review from ashwani2k

Assignees

@unmarshall unmarshall

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rishabh-11 @unmarshall @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-ci-robot