Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch GCR -> Artifact-Registry #93

Merged
merged 3 commits into from
Jan 2, 2024
Merged

switch GCR -> Artifact-Registry #93

merged 3 commits into from
Jan 2, 2024

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Dec 11, 2023

GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

  • europe-docker.pkg.dev/gardener-project/snapshots for snapshots
  • europe-docker.pkg.dev/gardener-project/releases for releases
  • europe-docker.pkg.dev/gardener-project/public for combined view of snapshots + releases

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr

Release note:

Change OCI Image Registry from GCR (`eu.gcr.io/gardener-project`) to Artifact-Registry (`europe-docker.pkg.dev/gardener-project/releases`). Users should update their references.

@gardener-prow gardener-prow bot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Dec 11, 2023
@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2023
@gardener-prow gardener-prow bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Dec 11, 2023
@ccwienk
Copy link
Member Author

ccwienk commented Dec 12, 2023

could you advice about the error about missing gomega:

github.com/gardener/gardener/hack/tools/gomegacheck@latest: module github.com/gardener/gardener@latest found (v1.85.0), but does not contain package github.com/gardener/gardener/hack/tools/gomegacheck

I cannot see how this might be related to my change 🤔

GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

- europe-docker.pkg.dev/gardener-project/snapshots for snapshots
- europe-docker.pkg.dev/gardener-project/releases for releases
- europe-docker.pkg.dev/gardener-project/public for read-access to
  snapshots + releases

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr
Copy link

gardener-prow bot commented Dec 14, 2023

@ccwienk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dependency-watchdog-check-vulnerabilities b462b90 link false /test pull-dependency-watchdog-check-vulnerabilities

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ccwienk
Copy link
Member Author

ccwienk commented Dec 15, 2023

according to failed check, there seem to be dependencies that should be updated:

Your code is affected by 6 vulnerabilities from the Go standard library.

however, considering this is not related to this pull-request, I assume it may be ignored in the context of this pull-request.

@ccwienk
Copy link
Member Author

ccwienk commented Dec 19, 2023

related: gardener/ci-infra#1067

also: bump

@rishabh-11 rishabh-11 added the kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly label Jan 2, 2024
@gardener-prow gardener-prow bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jan 2, 2024
Copy link
Collaborator

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2024
Copy link

gardener-prow bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rishabh-11

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

gardener-prow bot commented Jan 2, 2024

LGTM label has been added.

Git tree hash: e05c33dc8480f032bb5e92afb48973dc92d05f40

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024
@gardener-prow gardener-prow bot merged commit 9ecc3a0 into master Jan 2, 2024
6 of 7 checks passed
@rishabh-11 rishabh-11 deleted the gcr-to-ar branch January 2, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants