Use ginkgolinter instead of self baked gomegacheck

[himanshu-kun]

/area dev-productivity
/kind cleanup

What this PR does / why we need it:
Switch from own gomegacheck linter to use an officially supported golangci-lint linter for ginkgo/gomega checks.

Additionally the linting erros in the tests have been fixed.

refer gardener/gardener#8769

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Use `ginkgolinter` instead of self baked `gomegacheck`

[gardener-prow]

@himanshu-kun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-dependency-watchdog-check-vulnerabilities	014aba5	link	false	/test pull-dependency-watchdog-check-vulnerabilities

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rishabh-11]

Thanks for the PR.
/lgtm

[gardener-prow]

LGTM label has been added.

Git tree hash: d40c37bd3d69b7b131e488eb9466d9b0b93edd18

[gardener-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rishabh-11

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rishabh-11]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment