Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded os disk type check in the worker controller. #353

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remove hardcoded os disk type check in the worker controller. #353

wants to merge 1 commit into from

Conversation

dkistner
Copy link
Member

How to categorize this PR?

/kind cleanup
/platform azure

What this PR does / why we need it:
Clean up a hardcoded os disk type check in the worker controller.

Which issue(s) this PR fixes:
Fixes #190

Special notes for your reviewer:
I will keep this in draft until we have migrated all cluster to use a valid os disk type.
For all other who are using the provider-azure extension I added a breaking release note to make them aware of this change.

Release note:

An explizit check for the os disk type in the worker controller has been removed. Please ensure that existing Azure Shoots which specify a type for the os disk use a valid one. The os disk type is configured per worker pool via `.spec.provider.workers[].volume.types`. The available volume types can be looked up in the `CloudProfile` via `spec.volumeTypes[]`. If the Shoot does not specify an os disk type then the default disk type for the corresponding machine type will be used. Please check the Azure machine documentation for more detail.

/invite @ialidzhikov @kon-angelo

@gardener-robot gardener-robot added kind/cleanup Something that is not needed anymore and can be cleaned up needs/review Needs review platform/azure Microsoft Azure platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 30, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 30, 2021
@gardener-robot
Copy link

@kon-angelo You have pull request review open invite, please check

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jan 30, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

@kon-angelo kon-angelo Awaiting requested review from kon-angelo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/cleanup Something that is not needed anymore and can be cleaned up lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/azure Microsoft Azure platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up the handling for .spec.provider.workers[].machine.volume.type=standard
3 participants
@dkistner @gardener-robot @gardener-robot-ci-3