Fix chart upgrades #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timebertt Thank you for your contribution. |
gardener-robot
added
the
size/xs
|
Thank you @timebertt for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
rickardsjp
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Thank you for your contribution, @timebertt
/lgtm
Side note for posterity: This is required for stakeholders who deploy their monitoring stack using helm charts. As of Gardener v1.80.0, the gardener-operator deploys gardener-metrics-exporter as a go component.
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes chart upgrades by removing the version-specific label from the deployment's selector.
Which issue(s) this PR fixes:
Fixes #93
Special notes for your reviewer:
Upgrading to a new version including this PR will require operators to delete the Deployment first, so that helm allows the upgrade.
Release note: