Replace golint with golangci-lint and update pipeline golang image #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
reviewed/ok-to-test
rickardsjp
force-pushed
the
upgrade-ci
branch
from
bd8a3ee
to
a041f8c
Compare
gardener-robot
added
size/m
gardener-robot-ci-1
added
reviewed/ok-to-test
istvanballok
requested changes
Feb 12, 2024
…image `golint` has been frozen and deprecated. Read more here: golang/go#38968 This commit replaces it with `golangci-lint`, which makes use of the golang analysis framework. Additionally, the image used by the pipeline is upgraded to go 1.22. The go image used to build the binary and the base image are upgraded to 1.22 and debian12, respectively.
Switching to golangci-lint uncovered some issues in the code. This commit intends to introduce as few code changes as necessary to allow linting to succeed.
rickardsjp
force-pushed
the
upgrade-ci
branch
from
a041f8c
to
fc6ab5b
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Replace golint with golangci-lint, update go version, and upgrade the base image.
golinthas been frozen and deprecated. Read more here:golang/go#38968
This commit replaces it with
golangci-lint, which makes use of the golanganalysis framework.
Additionally, the image used by the pipeline is upgraded to go 1.22.
The go image used to build the binary and the base image are upgraded to
1.22 and debian12, respectively.
Switching to golangci-lint uncovered some issues in the code. This PR
intends to introduce as few code changes as necessary to allow linting
(and therefore builds) to succeed.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
cc @istvanballok
Release note: