Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Shoots with Kubernetes version == 1.24 #8989

Merged
merged 44 commits into from
Feb 27, 2024

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Dec 22, 2023

How to categorize this PR?

/kind cleanup

What this PR does / why we need it:
Drop support for Shoots, Seeds and Gardens with Kubernetes version == 1.24.

Notable changes:

Which issue(s) this PR fixes:
Part of #8921

Special notes for your reviewer:
Please follow the dedicated commits for easy reviewing.

Release note:

⚠️ Gardener does no longer support garden, seed, or shoot clusters with Kubernetes versions == 1.24. Make sure to upgrade all existing clusters before upgrading to this Gardener version.
The `spec.kubernetes.allowPrivilegedContainers` field in the Shoot API is deprecated and will be removed in a future version. This field is not relevant to Shoots with kubernetes versions >= 1.25. Please adapt your controllers accordingly.

@gardener-prow gardener-prow bot added kind/cleanup Something that is not needed anymore and can be cleaned up cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 22, 2023
@shafeeqes shafeeqes changed the title Drop support for Shoots with Kubernetes version < 1.24 Drop support for Shoots with Kubernetes version == 1.24 Dec 22, 2023
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2023
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 25, 2023
@acumino
Copy link
Member

acumino commented Jan 4, 2024

/assign

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2024
@gardener-prow gardener-prow bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 5, 2024
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2024
@shafeeqes shafeeqes force-pushed the cleanup/k8s-1.24 branch 3 times, most recently from 91b0ffa to cf647b3 Compare January 9, 2024 06:15
@oliver-goetz
Copy link
Member

/assign

@shafeeqes
Copy link
Contributor Author

shafeeqes commented Jan 9, 2024

/hold until gardener v1.89 is released due to a change in plans of the expiry of v1.24.

@gardener-prow gardener-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2024
@shafeeqes
Copy link
Contributor Author

Force-pushed to resolve the conflicts.

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
Copy link
Contributor

gardener-prow bot commented Feb 27, 2024

LGTM label has been added.

Git tree hash: 9bdf91019c809065c31ec6ccbe0e6c42693a3f7d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants