Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move network-problem-detector to observability #9092

Merged
merged 7 commits into from
Feb 8, 2024
Merged

move network-problem-detector to observability #9092

merged 7 commits into from
Feb 8, 2024

Conversation

Sallyan
Copy link
Contributor

@Sallyan Sallyan commented Jan 30, 2024 •
edited

How to categorize this PR?
The health check for extensions are conducted within condition SystemComponentsHealthy.
For extension network-problem-detector which is a tool helps to diagnose and investigate shoot network problems.
When network-problem-detector encounters an issue for some reason, it will set SystemComponentsHealthy to false.
Actually this extension would not affect shoot functionality.
To provide a more accurate representation of system health and reduce the frequency of SystemComponentsUnHealthy alert, this PR will add condition ObservabilityComponentsHealthy. Then it will allow extension register health check type for ShootObservabilityComponentsHealthy

/area monitoring
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Add condition type `ObservabilityComponentsHealthy` for extension health check, it will allow extensions to register with this type.

@gardener-prow gardener-prow bot added area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jan 30, 2024
@Sallyan Sallyan marked this pull request as draft January 30, 2024 09:25
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jan 30, 2024

Hi @Sallyan. Thanks for your PR.

I'm waiting for a gardener member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-prow gardener-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2024
rfranzke
rfranzke requested changes Jan 30, 2024
View reviewed changes
pkg/gardenlet/controller/shoot/care/health.go Outdated Show resolved Hide resolved
pkg/gardenlet/controller/shoot/care/health.go Outdated Show resolved Hide resolved
pkg/gardenlet/controller/shoot/care/health.go Outdated Show resolved Hide resolved
@Sallyan
Copy link
Contributor Author

Sallyan commented Feb 1, 2024

Draft PR in network-problem-detector extension gardener/gardener-extension-shoot-networking-problemdetector#119

@Sallyan Sallyan marked this pull request as ready for review February 2, 2024 08:56
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 2, 2024
@oliver-goetz
Copy link
Member

/ok-to-test

@gardener-prow gardener-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2024
@Sallyan
Copy link
Contributor Author

Sallyan commented Feb 4, 2024

/retest

@Sallyan
Copy link
Contributor Author

Sallyan commented Feb 4, 2024

/retest

@Sallyan
Copy link
Contributor Author

Sallyan commented Feb 5, 2024

/test pull-gardener-e2e-kind

rfranzke
rfranzke reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Can you please add a release note?

@rfranzke
Copy link
Member

rfranzke commented Feb 6, 2024

/retest

@rfranzke
Copy link
Member

rfranzke commented Feb 6, 2024 •
edited

Please update https://github.com/gardener/gardener/blob/master/docs/extensions/shoot-health-status-conditions.md#what-can-extensions-do-to-contribute-to-gardeners-health-checks accordingly.

/cc @acumino
since you enhanced this part of the docs in #7462

@gardener-prow gardener-prow bot requested a review from acumino February 6, 2024 09:34
@acumino
Copy link
Member

acumino commented Feb 6, 2024

/assign

@Sallyan
Copy link
Contributor Author

Sallyan commented Feb 7, 2024

@rfranzke @acumino Updated the docs accordingly and added the release note. Please help to review.

shafeeqes
shafeeqes reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one minor nit

docs/extensions/shoot-health-status-conditions.md Outdated Show resolved Hide resolved
@shafeeqes
Copy link
Contributor

Thanks!
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 8, 2024

LGTM label has been added.

Git tree hash: 4b03ebbc484f4d3f62b3c99d2832c83f21aa8bb4

@shafeeqes
Copy link
Contributor

/retest-required

@Sallyan
Copy link
Contributor Author

Sallyan commented Feb 8, 2024

/test pull-gardener-e2e-kind

acumino
acumino reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

rfranzke
rfranzke reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2024
@gardener-prow gardener-prow bot merged commit ddfeb9c into gardener:master Feb 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke requested changes

@acumino acumino acumino left review comments

@ary1992 ary1992 Awaiting requested review from ary1992

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

@shafeeqes shafeeqes Awaiting requested review from shafeeqes

Assignees

@rfranzke rfranzke

@acumino acumino

@shafeeqes shafeeqes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring Monitoring (including availability monitoring and alerting) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Sallyan @oliver-goetz @rfranzke @acumino @shafeeqes