-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync cluster CA to ConfigMap
and use it in shoots/{admin,viewer}kubeconfig
subresource
#9123
Sync cluster CA to ConfigMap
and use it in shoots/{admin,viewer}kubeconfig
subresource
#9123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive PR @petersutter, nice! Thanks for the great commit structure!
Could you please also adapt the occurrences in test/e2e
(example)?
Thanks, let's get this merged after you rebased and the tests are fixed. |
Renamed functions to allow reuse for configmaps and secrets.
Updated all occurrences of the renamed functions.
…CA via `ConfigMap` Fallback to `<shoot-name>.ca-cluster` `Secret` if a `ConfigMap` with the same name is not found
0ffe502
to
8f9f531
Compare
@petersutter: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: fb80533f2df808c1516752ee9233ce83c819b6ae
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area usability
/area security
/kind enhancement
What this PR does / why we need it:
With this PR the cluster CA is synced to a
<shoot-name>.ca-cluster
ConfigMap
in the project namespace of the garden cluster. Theshoots/{admin,viewer}kubeconfig
subresource retrieves it from there instead of using theSecret
resource.It falls back to the
Secret
if theConfigMap
has not been synced yet.Which issue(s) this PR fixes:
Fixes #9091
Special notes for your reviewer:
Release note: