Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus alert for nodes not ready on seeds #9127

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Add Prometheus alert for nodes not ready on seeds #9127

merged 1 commit into from
Feb 14, 2024

Conversation

adenitiu
Copy link
Contributor

@adenitiu adenitiu commented Feb 6, 2024

How to categorize this PR?

/area monitoring
/kind enhancement

What this PR does / why we need it:
This PR adds a new alerting rule for nodes that are unhealthy / unschedulable for more than 10 mins, during a time window of 30 mins, ignoring actions taken by the ClusterAutoscaler or by a possible K8S upgrade activity.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @istvanballok @rickardsjp

Release note:

Add Prometheus alert for unhealthy seed node.

@gardener-prow gardener-prow bot added area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Feb 6, 2024
@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 6, 2024
@adenitiu
Copy link
Contributor Author

adenitiu commented Feb 6, 2024

/retest

@oliver-goetz
Copy link
Member

Thanks 😄
/approve

/cc @istvanballok @rickardsjp
for lgtm

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
Copy link
Contributor

@rickardsjp rickardsjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
sorry for the delay!

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
Copy link
Contributor

gardener-prow bot commented Feb 14, 2024

LGTM label has been added.

Git tree hash: 8e42a8302c6f246da45b6de8cc71d6f78aadfa5b

Copy link
Contributor

gardener-prow bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz, rickardsjp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot merged commit bb4e628 into gardener:master Feb 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring Monitoring (including availability monitoring and alerting) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants