Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote UseGardenerNodeAgent feature gate to beta #9161

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Feb 9, 2024

How to categorize this PR?

/area open-source
/kind enhancement

What this PR does / why we need it:
Promote UseGardenerNodeAgent feature gate to beta and turn it on by default.

Which issue(s) this PR fixes:
Part of #8023

Special notes for your reviewer:
/cc @oliver-goetz

Release note:

The `UseGardenerNodeAgent` feature gate has been promoted to beta and is now turned on by default. 

@gardener-prow gardener-prow bot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2024
docs/deployment/feature_gates.md Outdated Show resolved Hide resolved
@rfranzke rfranzke force-pushed the promote-usegna branch 2 times, most recently from 2ce664c to 1c3209d Compare February 10, 2024 14:55
@rfranzke
Copy link
Member Author

/retest

@oliver-goetz
Copy link
Member

The failing unit tests look like a real issue 😅

@gardener-prow gardener-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2024
@rfranzke rfranzke force-pushed the promote-usegna branch 2 times, most recently from 03d1d92 to 8f4a894 Compare February 12, 2024 13:05
@gardener-prow gardener-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Feb 12, 2024
@oliver-goetz
Copy link
Member

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2024
Copy link
Contributor

gardener-prow bot commented Feb 12, 2024

LGTM label has been added.

Git tree hash: 7ce1a8bc53182ec8e74d8c7cca7a8f6ecd76ba4e

Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke
Copy link
Member Author

/approve

Copy link
Contributor

gardener-prow bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@gardener-prow gardener-prow bot merged commit 13afd0e into gardener:master Feb 13, 2024
16 checks passed
@rfranzke rfranzke deleted the promote-usegna branch February 13, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants